downshift-js / downshift-js/downshift

[useSelect] Selecting item with spacebar in firefox reopens the menu

Open
#1,197 5 comments 0 reactions 0 assignees View on GitHub
bug help wanted needs investigation
Dominant language
JavaScript
Stars
12.3k
Forks
936
PR merge metrics
No merged PRs in 30d

Description

- `downshift` version: 6.0.6
- `firefox` version: 82.0.3

**Relevant code or config**

Error present in reference implementation: https://www.downshift-js.com/use-select

**What you did**:

With firefox, open a menu and select an item with the spacebar key

**What happened**:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the `__menu_keydown_space_button__` is emitted, and on key up the `__togglebutton_click__` is emitted.

Error is not present in chrome.

**Reproduction repository**:

**Problem description**:

**Suggested solution**:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.