dotnetcore / dotnetcore/Magicodes.IE

Pls remove throw new ArgumentException("Tablename has spaces") at ExcelTableCollection.ValidateTableName,xlsx is allowed worksheet name Contains empty

Open
#558 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.2k
Forks
495
PR merge metrics
No merged PRs in 30d

Description

### Expected behaviour
Tell us what should happen.
```
public class ExcelTableCollection : IEnumerable, IEnumerable
private void ValidateTableName(string Name)
{
if (string.IsNullOrEmpty(Name))
{
throw new ArgumentException("Tablename is null or empty");
}
char c = Name[0];
if (!char.IsLetter(c) && c != '_' && c != '\\')
{
throw new ArgumentException("Tablename start with invalid character");
}
if (Name.Contains(" "))
{
throw new ArgumentException("Tablename has spaces");
}
}
```
### Actual behaviour
Tell us what happens instead. Provide a log message if relevant.
xlsx is allow worksheet name Contains empty
### I'm seeing this behaviour on
_Remove this hint: these checkboxes can be checked like this: [x]_

- [ x] Magicodes.IE.Excel
#### package versions
Example: Magicodes.IE.Excel 2.2.2, Magicodes.IE.Pdf 1.0

### So how can we reproduce this?
_Remove this hint: Pick one of these - use the Preview feature of this editor to get a sense which option we like best_

#### Awesome :star::star::star::star::star:
Provide a (link to a) minimal demo app showing the faulty behaviour.

#### Sweet :star::star::star::star:
Provide a concise code sample which can upload attachments.

#### Good :star::star::star:
Provide your own app and instructions how to reproduce the issue.

#### Meh :star::star:
Provide a code sample with a bunch of magic parameters which I need to interpolate by guessing to reconstruct the actual runtime code.

#### Worst :poop:
Say the source code can't be disclosed and refuse to provide any of the above. Expect this issue to be closed by a bunch of angry aliens :alien::alien::alien::alien::alien: that will hunt you down and :fire: your :computer:. You've been warned. :fire_engine:

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.