dotnet / dotnet/yarp

ForwarderMiddleware references prior cluster

Open
#1,750 3 comments 0 reactions 0 assignees View on GitHub
Type: Bug
Dominant language
C#
Stars
9.6k
Forks
933
Avg merge
12d 18h
Merged PRs (30d)
2

Description

When using the reassign proxy requests as described in https://microsoft.github.io/reverse-proxy/articles/ab-testing.html, the ForwarderMiddleware continues to reference the original cluster via the Route.

https://github.com/microsoft/reverse-proxy/blob/a2165f4d9c53595d9e080c056f04e7e83761fbf0/src/ReverseProxy/Forwarder/ForwarderMiddleware.cs#L41

This affects logs and counters:
https://github.com/microsoft/reverse-proxy/blob/a2165f4d9c53595d9e080c056f04e7e83761fbf0/src/ReverseProxy/Forwarder/ForwarderMiddleware.cs#L45
https://github.com/microsoft/reverse-proxy/blob/a2165f4d9c53595d9e080c056f04e7e83761fbf0/src/ReverseProxy/Forwarder/ForwarderMiddleware.cs#L69

There shouldn't be any functional impact.

This might be hard to fix because the cluster object referenced from the route is the only one with these fields.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.