dotnet / dotnet/wpf

Invalid syntax inside Ribbon control templates - Binding="{Binding (0)}"

Open
#647 2 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
C#
Stars
7.7k
Forks
1.3k
Avg merge
1d 11h
Merged PRs (30d)
61

Description

Here's an apparent bug which I've just ran into myself and then found a reference to on Stack Overflow:

See https://stackoverflow.com/a/21880114/3195477 and https://stackoverflow.com/a/39002469/3195477

Summary:

I found this:

<DataTriggerValue="True"Binding="{Binding (0)}">

triggers in RibbonMenuButton template. What does it mean?

...

The issue is that in the standard ribbon templates there are many wrong placeholders
<ConditionBinding="{Binding (0)}"Value="True"/>

Long story short, you need to change the above into, for example:
<ConditionBinding="{Binding Zero }"Value="True"/>

This was reported once in the past on Microsoft Connect, but apparently never fixed. Here's an archive of that page. The download provided by Microsoft on that page seems to be no longer accessible.

_This issue has been moved from https://developercommunity.visualstudio.com/content/problem/545784/invalid-syntax-inside-ribbon-control-templates-bin.html
VSTS ticketId: 855260_
_These are the original issue comments:_

Visual Studio Feedback System on 4/24/2019, 08:02 PM (8 days ago):

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Dave Hollman on 4/25/2019, 04:31 AM (8 days ago):

Here's another Stack Overflow post reporting what seems to be the same problem:

https://stackoverflow.com/questions/36350664/error-in-nested-ribbonapplicationmenuitem

_These are the original issue solutions:_
(no solutions)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.