dotnet / dotnet/wpf

SatelliteDllsProjectOutputGroup should produce items with Culture metadata

Open
#2,914 0 comments 1 reaction 0 assignees View on GitHub
Bug
Dominant language
C#
Stars
7.7k
Forks
1.3k
Avg merge
1d 11h
Merged PRs (30d)
61

Description

* .NET Core Version: SDK 3.1.200
* Does the bug reproduce also in WPF for .NET Framework 4.8?: Yes
* Is this bug related specifically to tooling in Visual Studio (e.g. XAML Designer, Code editing, etc...)? No

**Problem description:**

Build authoring that relies on the items output by the `SatelliteDllsProjectOutputGroup` target malfunctions when a .NET SDK project switches from `Microsoft.NET.Sdk` to `Microsoft.NET.Sdk.WindowsDesktop` because `Microsoft.WinFx.targets` defines the target differently than `Microsoft.Common.CurrentVersion.targets` defines it.
In particular, the standard implementation produces `SatelliteDllsProjectOutputGroupOutputIntermediate` items with `Culture` metadata but the Microsoft.WinFx.targets implementation does not.

Standard: https://github.com/microsoft/msbuild/blob/73c84c6bd9cf8a73d7d5c9caae65771293ad01ea/src/Tasks/Microsoft.Common.CurrentVersion.targets#L5738

WinFx implementation:
https://github.com/dotnet/wpf/blob/e91c42604c308f726c723aae06f568b27925b888/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFx.targets#L807-L814

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.