dotnet / dotnet/wpf

DataBindEngine.CrossThreadThreshold const is ambiguous with code comment

Open
#2,847 1 comment 2 reactions 0 assignees View on GitHub
Enhancement Requested
Dominant language
C#
Stars
7.7k
Forks
1.3k
Avg merge
1d 11h
Merged PRs (30d)
61

Description

the internal constant DataBindEngine.CrossThreadThreshold is defined as:

`internal const int CrossThreadThreshold = 50000; // 50 msec`

This const is used in places that compare ticks, so 50000 is actually 5 milliseconds, not 50 as the comment suggests. I'm happy to push up a fix for this, either the value of the const to reflect 50 msec or the comment to reflect that the value is 5 msec, but it's unclear exactly what the intent is here?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.