dotnet / dotnet/wpf

WPF tasks return false from ITask.Execute without logging errors

Open
#2,778 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
7.7k
Forks
1.3k
Avg merge
1d 11h
Merged PRs (30d)
61

Description

.NET Core SDK (reflecting any global.json):
Version: 3.1.200
Commit: c5123d973b

**Problem description:**
Certain WPF targets can return false without logging errors.

To help customers diagnose "failed" builds without errors, [MSBuild has started logging errors when a task returns "false" from Execute without logging an error](https://github.com/microsoft/msbuild/pull/4940).

This has started catched WPF tasks:

```
Severity Code Description Project File Line Suppression State
Error MSB4132 The "GenerateTemporaryTargetAssembly" task returned false but did not log an error. Microsoft.VisualStudio.Editors C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319\Microsoft.WinFx.targets 444
Error MSB4132 The "GenerateTemporaryTargetAssembly" task returned false but did not log an error. Microsoft.VisualStudio.ProjectSystem.Managed.VS C:\WINDOWS\Microsoft.NET\Framework\v4.0.30319\Microsoft.WinFx.targets 444
Warning MSB4132 The "MarkupCompilePass1" task returned false but did not log an error. Microsoft.VisualStudio.LanguageServices.VisualBasic C:\Program Files\dotnet\sdk\3.1.200\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets 225
```
I don't have a repro, but I've hit all above many times over the past few weeks. A pass should be done to verify that that these tasks log an error every occasion that they return false from ITask.Execute.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.