dotnet / dotnet/wpf

Remove the "BuildingProject" directive completely from WinFx.targets

Open
#1,914 4 comments 0 reactions 1 assignee Claimed by @ryalanms View on GitHub
Bug
Dominant language
C#
Stars
7.7k
Forks
1.3k
Avg merge
1d 11h
Merged PRs (30d)
61

Description

I think we should just remove the "BuildingProject" directive completely - it just adds confusion to this block as to when it is set/not set. This used to be used to detect legacy design-time builds, but this targets file will not be run in legacy.

_Originally posted by @davkean in https://github.com/dotnet/wpf/pull/1895_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.