dotnet / dotnet/wpf

Fluent2: Controls Are NOT Designed for Custom Height

Open
#10,359 1 comment 1 reaction 0 assignees View on GitHub
Win 11 Theming
Dominant language
C#
Stars
7.7k
Forks
1.3k
Avg merge
1d 11h
Merged PRs (30d)
61

Description

### Description

Fluent2 controls suffer from a few issues with height:

1) They are too tall by default. This is especially obvious with the ComboBox which is far too tall by default. I suspect the item margins/padding do not follow WinUI 3.
2) Related with point 1, several controls are NOT designed for the default 32px height. I'm pretty sure this is the default in WinUI3 and needs to apply here as well?
2) The controls do NOT support custom heights. I already noted this separately with the DatePicker calendar button. However, setting a forced height of 32px flatly doesn't work for ComboBox and has issues with DatePicker. All controls need to be audited.

### Reproduction Steps

Controls with issues so far:

- ComboBox
- DatePicker

... please review for more. I will add them if/when I find them as well.

### Expected behavior

See WinUI3 gallery

### Actual behavior

See above

### Regression?

_No response_

### Known Workarounds

_No response_

### Impact

_No response_

### Configuration

_No response_

### Other information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.