dotnet / dotnet/winforms

Review use of `BC41004` warning

Open
#3,936 3 comments 0 reactions 1 assignee Claimed by @KlausLoeffelmann View on GitHub
area-VisualBasic
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
1d 13m
Merged PRs (30d)
85

Description

The latest changes from dotnet/runtime (https://github.com/dotnet/winforms/pull/3804) couldn't be merged due to build failures:
```
##[error]src\Microsoft.VisualBasic.Forms\src\Microsoft\VisualBasic\Devices\Network.vb(822,20): error BC41004: (NETCORE_ENGINEERING_TELEMETRY=Build) First statement of this 'Sub New' should be an explicit call to 'MyBase.New' or 'MyClass.New' because the 'Public Overloads Sub New()' in the base class 'WebClient' of 'WebClientExtended' is marked obsolete: 'Use HttpClient instead.'
```

The error was suppressed in https://github.com/dotnet/winforms/pull/3804/commits/590399f903a2bc5a3ac8ef5644e3337b0b0f1179.

The suppression needs to be reviewed, and corrected.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.