dotnet / dotnet/winforms

DragDrop unit tests hang, should be integration tests

Open
#3,336 3 comments 0 reactions 0 assignees View on GitHub
test-bug
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
1d 13m
Merged PRs (30d)
85

Description

**.NET Core Version:**
master

**Have you experienced this same bug with .NET Framework?:**
not applicable

**Problem description:**
DoDragDrop tests in ToolStripItemTests and ControlTests are hanging CI.

Not sure if its worth to root-cause the hang, I think they should be integration tests instead as proper drag'n'drop tests need mouse interaction, otherwise OLE probably exits out very early. These tests basically just cover a failure case which in practice nobody is interested in (and can easily be covered by the integration test as well). Sure, its useful to ensure that a noop failure case stays a noop failure case, but it may give a false sense of test coverage if there is actually no test of the code paths used for successful drag'n'drop.

**Expected behavior:**
* DoDragDrop tests should not hang CI
* DoDragDrop tests should cover non-failure-cases (requires integration test)

**Minimal repro:**
* run the tests with xunit.stafact updated to 1.0.33 or unskip them from PR #3276

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.