dotnet / dotnet/winforms

cachedTypes in AssemblyNamesTypeResolutionService is unreachable

Open
#229 6 comments 0 reactions 0 assignees View on GitHub
:beetle: bug area-Serialization-Resx tenet-compatibility
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
1d 13m
Merged PRs (30d)
85

Description

**Problem description:**

[Here ](https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Resources/ResXDataNode.cs#L977) the field [cachedTypes](https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Resources/ResXDataNode.cs#L824) is currently unreachable because it relies on `Assembly.GlobalAssemblyCache` which is false in .NET Core and `IsNetFrameworkAssembly`, which is also always false because it tests if assembly `Location` path is .NET Framework path, while (on Windows) .NET Core assemblies are on `C:\Program Files\dotnet\shared\Microsoft.NETCore.App\...` path.

**Actual behavior:**

Types are not cached

**Expected behavior:**

.NET Core types are cached (?)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.