dotnet / dotnet/winforms

Write test(s) to ensure that all TypeConverter and Editor Attributes on internals are properly routed

Open
#2,172 1 comment 0 reactions 1 assignee Claimed by @JeremyKuhne View on GitHub
test-enhancement
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
1d 13m
Merged PRs (30d)
85

Description

For each `TypeConverter` and `Editor` attribute connecting a type to its type converter or editor by a fully qualified string, we need a `TypeForwardTo` attribute in the corresponding facade. This is required as GenFacades will not automatically generate `TypeForwardTo` statements for internals.

Please see https://github.com/dotnet/winforms/pull/2078#discussion_r337787642 for more details on the history of this need and discussion.

Suggestion: write a unit test that rolls over every assembly we own and uses reflection to determine which internal types, properties, and methods have these attributes. Then, for each of those that exist, determine whether or not that type was in an assembly that we now type forward from. If so, ensure that there is a manually added `TypeForwardTo` statement in the facades.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.