dotnet / dotnet/winforms

Should use GetDllVersion for seeing what common controls is available

Open
#1,463 0 comments 0 reactions 1 assignee Claimed by @JeremyKuhne View on GitHub
enhancement
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
20h 23m
Merged PRs (30d)
103

Description

In [`Application.InitializeComCtlSupportsVisualStyles()`] we're scraping for known exports to determine the version of common controls that is available. That's error prone and why they've added `DllGetVersion` to the various shell dlls. There shouldn't be a "binding" issue as called out in the code.

Feel free to use my implementation as a reference, I don't need credited. https://github.com/JeremyKuhne/WInterop/blob/master/src/WInterop.Desktop/Windows/Windows.cs#L712

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.