dotnet / dotnet/winforms

InvokeAsync does not finally check CancellationToken

Open
#12,696 8 comments 1 reaction 1 assignee Claimed by @KlausLoeffelmann View on GitHub
:beetle: bug
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
20h 23m
Merged PRs (30d)
103

Description

In contrast to the other overloads, `InvokeAsync` in https://github.com/dotnet/winforms/blob/0ce1218949e478b130091479b7551eb1329804cb/src/System.Windows.Forms/src/System/Windows/Forms/Control_InvokeAsync.cs#L244 does not check the `cancellationToken` before finally invoking the delegate.

This should be done in order to
- be consistent
- avoid an unnecessary invocation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.