dotnet / dotnet/winforms

The visual basic code source does not match any code style

Open
#11,136 2 comments 0 reactions 2 assignees Claimed by @paul1956 View on GitHub
area-VisualBasic enhancement priority-3
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
1d 13m
Merged PRs (30d)
85

Description

### Background and motivation

I would like to clean up the style of the code using automatic tools that understand VB and manually where tools don't exist.

So remove Options from Source file and move to project file, the project file already has 2 of 3 settings used in source.
Change Option Explicate On which is true in all but a few files.
Indent the Text of XML comments by 1 space.
Remove blank lines between Class and Namespace
Organize imports, Privates, Publics, according to tools available options.

None of this involves any code changes but will make it easier to test and comprehend with the possible exception of 1 function call that already is causing a suggestion.

### API Proposal

N/A

### API Usage

N/A

### Alternative Designs

I could do this as 1 PR or first clean up formatting issues and then reorganize the code layout or I could only do this to files I am already touching or any combination.

Getting nit comments about formatting files that started out as a mess and still are doesn't make PR reviews fun.

### Risks

Low as no code is being changed

### Will this feature affect UI controls?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.