dotnet / dotnet/winforms

Annotate or get rid of the null-forgiving operators in PropertyGrid.cs and related files.

Open
#10,686 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
C#
Stars
4.9k
Forks
1.1k
Avg merge
1d 13m
Merged PRs (30d)
85

Description

This is a follow up on https://github.com/dotnet/winforms/pull/10110#discussion_r1360819144.

Investigate if https://github.com/dotnet/winforms/blob/f7d6850caa53f62816d977e737d6cb2a537f0d9a/src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGrid.cs#L3770 can be refactored to convince nullability analyzers that fields that are allocated in this method are not null. This would allow us to get rid of the null-forgiving operators. If not realistic, then then each null-forgiving operator should be annotated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.