dotnet / dotnet/windowsdesktop
Profile Classification Should Come from Repo that Produces DLL
- Dominant language
- Shell
- Stars
- 211
- Forks
- 71
- Avg merge
- 2h 18m
- Merged PRs (30d)
- 81
Description
In windowsdesktop we have profiling for dlls in the [ref](https://github.com/dotnet/windowsdesktop/blob/1bb8762826ee0ab83551712c468d4acc970dd2a8/src/windowsdesktop/src/sfx/Directory.Build.props#L66-L89) and [runtime](https://github.com/dotnet/windowsdesktop/blob/1bb8762826ee0ab83551712c468d4acc970dd2a8/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Runtime.sfxproj#L22-L67) pack
Currently the profile specification for dlls in the ref/runtime pack is disconnected from the repos that actually produce them, which can easily lead to mis profiling the dlls.
In WinForms, we have https://github.com/dotnet/winforms/blob/main/pkg/Microsoft.Private.Winforms/sdk/dotnet-windowsdesktop/System.Windows.Forms.FileClassification.props which profiles all winforms dlls for the ref pack and windowsdesktop simply pulls this in via https://github.com/dotnet/windowsdesktop/blob/main/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Ref.sfxproj#L25. We should set up a similar system for WPF and for the runtime pack to help with the disconnect and avoid mis profiling dlls.
Note that when it comes to the runtime pack, analyzers should not be included https://github.com/dotnet/windowsdesktop/pull/4227#issue-2179339170
Contributor guide
Assessment
This issue has not been assessed yet.