dotnet / dotnet/windowsdesktop
Enforce WindowsDesktop DLL/EXE files having non-zero FileVersion
- Dominant language
- Shell
- Stars
- 211
- Forks
- 71
- Avg merge
- 2h 18m
- Merged PRs (30d)
- 81
Description
https://github.com/dotnet/core-setup/blob/851859e9e07eda7adb2dcf129b0d6fb3cab411e3/src/pkg/projects/windowsdesktop/dir.props#L8-L17
https://github.com/dotnet/core-setup/pull/5682 added validation that all DLL files in the platform manifest have a `FileVersion` that isn't null or 0.0.0.0. These WindowsDesktop files should be looked at so the validation suppression can be removed.
This is only a sanity check: there may be a valid reason, and this doesn't seem like a high priority.
First step is to identify where these files are created.
Contributor guide
Research direction
Start with src/pkg/projects/windowsdesktop/dir.props at lines 8–17 and review the validation added by core-setup#5682. Identify where the WindowsDesktop DLL and EXE files are created, then determine whether each has a non-zero FileVersion. Done means the suppression can be removed or a valid reason for it is documented.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system, desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100