dotnet / dotnet/wcf

Refactor and/or remove dead code in channel factory async close path

Open
#1,087 2 comments 0 reactions 1 assignee Claimed by @roncain View on GitHub
Backlog enhancement
Dominant language
C#
Stars
1.8k
Forks
576
Avg merge
6d 9h
Merged PRs (30d)
2

Description

PR #1071 made the channel factory async close path remain async. This appears to have made the synchronous code path unreachable, because the low level IAsyncCommunicationObject logic uses the async close path even for sync closes

To resolve this issue:
- Establish via code coverage and analysis that the TypedServiceChannelFactory and ServiceChannelFactory OnClose and BeginClose have become unreachable
- Remove what can be removed or refactor to use common code path

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.