dotnet / dotnet/vscode-dotnet-runtime

[question] Why do you set [Net.ServicePointManager]::SecurityProtocol explicitly when running dotnet-install.ps1 script

Open
#219 1 comment 0 reactions 0 assignees View on GitHub
discussion
Dominant language
TypeScript
Stars
209
Forks
455
PR merge metrics
No merged PRs in 30d

Description

I am curious why do you add TLS1.2 to [Net.ServicePointManager]::SecurityProtocol explicitly instead of using the system default, which is more secure?

And this behavior only exists on Windows. The [dotnet-install script documentation](https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script) does not mention this either

https://github.com/dotnet/vscode-dotnet-runtime/blob/112e74c75ff15e7951860749fb46e4ff53d4bfa0/vscode-dotnet-runtime-library/src/Acquisition/AcquisitionInvoker.ts#L38

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.