dotnet / dotnet/vscode-csharp

Known O# LSP issues

Open
#5,429 1 comment 3 reactions 1 assignee Claimed by @dibarbet View on GitHub
OmniSharp
Dominant language
TypeScript
Stars
3.1k
Forks
737
Avg merge
18h 40m
Merged PRs (30d)
31

Description

When running with the C# extension built from the feature/lsp-engine branch and omnisharp.enableLSPDriver set to "true".

- [x] LSP Logging to the OmniSharp log is duplicating every line (https://github.com/OmniSharp/omnisharp-roslyn/pull/2473)
- [ ] O# LSP sends across multiple registrations for the same command. One for the C# handlers and a second for the Cake handlers. This causes LSP features to not register. Removing the OmniSharp.Cake.dll from the O# distribution is a workaround. DavidB suggests having O# LSP merge the registrations by combining the document selectors. (https://github.com/OmniSharp/omnisharp-roslyn/pull/2467)
- [ ] Some features do not consistently trigger (Signature Help, Format Document on Type,).
- [ ] Some features seems to double register (Completion, Hover,).
- [ ] Need to add support for metadata documents and source generated documents.
- [ ] CodeLens handler does not support Run/Debug Test lenses.
- [ ] InlayHint handler can't be implemented until csharp-language-server-protocol updates to 3.17 api.
- [ ] Diagnostics handler is not implemented.
- [ ] Need to implement custom LSP commands for some O# functionality FixAll, Run/Debug Tests in Context.
- [ ] Many messages are still being sent to O# using their O# protocol adapter (RequestWorkspaceInformation, etc...). This may not be an issues unless O# wants to remove the adapter and O# protocol support.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.