dotnet / dotnet/vscode-csharp

Quick fixes are duplicated when EnforceCodeStyleInBuild is enabled

Open
#5,217 0 comments 0 reactions 0 assignees View on GitHub
OmniSharp
Dominant language
TypeScript
Stars
3.1k
Forks
737
Avg merge
17h 56m
Merged PRs (30d)
21

Description

## Environment data
`dotnet --info` output:
```
.NET SDK (reflecting any global.json):
Version: 6.0.101
Commit: ef49f6213a

Runtime Environment:
OS Name: arch
OS Version:
OS Platform: Linux
RID: arch-x64
Base Path: /usr/share/dotnet/sdk/6.0.101/

Host (useful for support):
Version: 6.0.1
Commit: 3a25a7f1cc

.NET SDKs installed:
5.0.404 [/usr/share/dotnet/sdk]
6.0.101 [/usr/share/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.13 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.1 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 5.0.13 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.1 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
```
VS Code version: 1.67.1
C# Extension version: v1.24.4

## OmniSharp log
```
[info]: OmniSharp.MSBuild.ProjectManager
Queue project update for '... .csproj'
[info]: OmniSharp.MSBuild.ProjectManager
Loading project: ... .csproj
[info]: OmniSharp.MSBuild.ProjectManager
Successfully loaded project file '... .csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
Update project: MediatrTest
[info]: OmniSharp.OmniSharpWorkspace
Adding analyzer reference: /usr/share/dotnet/sdk/6.0.101/Sdks/Microsoft.NET.Sdk/codestyle/cs/Microsoft.CodeAnalysis.CodeStyle.dll
[info]: OmniSharp.OmniSharpWorkspace
Adding analyzer reference: /usr/share/dotnet/sdk/6.0.101/Sdks/Microsoft.NET.Sdk/codestyle/cs/Microsoft.CodeAnalysis.CodeStyle.Fixes.dll
[info]: OmniSharp.OmniSharpWorkspace
Adding analyzer reference: /usr/share/dotnet/sdk/6.0.101/Sdks/Microsoft.NET.Sdk/codestyle/cs/Microsoft.CodeAnalysis.CSharp.CodeStyle.dll
[info]: OmniSharp.OmniSharpWorkspace
Adding analyzer reference: /usr/share/dotnet/sdk/6.0.101/Sdks/Microsoft.NET.Sdk/codestyle/cs/Microsoft.CodeAnalysis.CSharp.CodeStyle.Fixes.dll
```

## Steps to reproduce

1. Open any .Net project
2. Add `true` directive to .csproj file

## Expected behavior
Only one quick fix is shown only once per warning.

## Actual behavior
Quick fix suggestion is duplicated: one is english and one with the system locale (russian in my case). See screenshot:
![image](https://user-images.githubusercontent.com/22894169/168814592-ab4bd005-46c3-4a7f-9372-ab83ead1ee3c.png)

## Additional context
I tried to experiment and found out that this error only appears when I use non-default system locale (for example ru_RU). If I switch to C locale before starting vscode by using `LANG=C code` command, the duplications disappear.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.