dotnet / dotnet/vscode-csharp

Omnisharp fails to start server with spaces in the path

Open
#4,491 1 comment 1 reaction 0 assignees View on GitHub
Bug OmniSharp Triaged
Dominant language
TypeScript
Stars
3.1k
Forks
737
Avg merge
17h 56m
Merged PRs (30d)
21

Description

## Issue Description ##
Omnisharp fails to start server with spaces in the path, example ```/Users/James 1 2/.vscode/extensions/ms-dotnettools.csharp-1.23.10/.omnisharp/1.37.8/run```. Similar to https://github.com/OmniSharp/omnisharp-vscode/issues/3608, but earlier in the run executable.

For what it's worth, I tried hardcoding the run executable variables to no avail. Also tried reverting to an earlier version with the same result.

Thanks!

## Steps to Reproduce ##
Start omnisharp in vscode with spaces in the executable path.

## Expected Behavior ##
Omnisharp escapes spaces on server start.

## Actual Behavior ##
Omnisharp doesn't escape them.

## Logs ##

### OmniSharp log ###
Starting OmniSharp server at 4/9/2021, 11:54:16 AM
Target: /Users/James 1 2/games/New Unity Project/New Unity Project.sln

OmniSharp server started.
Path: /Users/James 1 2/.vscode/extensions/ms-dotnettools.csharp-1.23.10/.omnisharp/1.37.8/run
PID: 27658

Cannot open assembly '1': No such file or directory.
[ERROR] Error: OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout' setting to override the default delay (one minute).

## Environment information ##

**VSCode version**: 1.55.1
**C# Extension**: 1.23.10

Mono Information
OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
Version: 5.0.202
Commit: db7cc87d51

Runtime Environment:
OS Name: Mac OS X
OS Version: 10.15
OS Platform: Darwin
RID: osx.10.15-x64
Base Path: /usr/local/share/dotnet/sdk/5.0.202/

Host (useful for support):
Version: 5.0.5
Commit: 2f740adc14

.NET SDKs installed:
5.0.202 [/usr/local/share/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.5 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.23 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.5 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

|Extension|Author|Version|
|---|---|---|
|csharp|ms-dotnettools|1.23.10|
|jupyter|ms-toolsai|2021.5.702919634|
|python|ms-python|2021.3.680753044|
|vscode-eslint|dbaeumer|2.1.19|
|vsliveshare|ms-vsliveshare|1.0.4116|;

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.