Debugger ignores module filter for modules with embedded symbols
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 737
- Avg merge
- 18h 40m
- Merged PRs (30d)
- 31
Description
## Environment data
`dotnet --info` output: 5.0.200-preview.20601.7
VS Code version: 1.52.1
C# Extension version: ms-dotnettools.csharp-1.23.8
.omnisharp 1.37.6-beta.16
## Steps to reproduce
1. settings.json:
```js
{
"csharp.unitTestDebuggingOptions": {
"allowFastEvaluate": true,
"enableStepFiltering": true,
"logging": {
"programOutput": true,
"elapsedTiming": true,
"engineLogging": false,
"exceptions": true,
"moduleLoad": false,
"threadExit": false,
"browserStdOut": false,
"processExit": true
},
"requireExactSource": true,
"suppressJITOptimizations": true,
"justMyCode": true,
"symbolOptions": {
"searchPaths": [],
"searchMicrosoftSymbolServer": false,
"searchNuGetOrgSymbolServer": false,
"moduleFilter": {
"mode": "loadOnlyIncluded",
"includeSymbolsNextToModules": false,
"includedModules": [
"MyUnitTests.dll",
]
}
}
}
}
```
2. Enable `All exceptions`

2. Debug a test.
3. Debugger breaks on non-user code.

## Expected behavior
Breakpoint settings should use symbolOptions or justMyCode setting. Or maybe we can have a different checkboxes for this.
## Actual behavior
Symbols of `xunit.runner.visualstudio.dotnetcore.testadapter.dll` and `xunit.runner.utility.netcoreapp10.dll` are loaded and we see a breakpoint on exception inside the xunit code. I can't disable `All Exceptions` because if an exception is thrown in a test, we don't interrupt it with the `User-Unhandled Exceptions` setting.
Contributor guide
Assessment
This issue has not been assessed yet.