dotnet / dotnet/vscode-csharp

Debugger ignores module filter for modules with embedded symbols

Open
#4,332 6 comments 0 reactions 0 assignees View on GitHub
Debugger OmniSharp
Dominant language
TypeScript
Stars
3.1k
Forks
737
Avg merge
18h 40m
Merged PRs (30d)
31

Description

## Environment data
`dotnet --info` output: 5.0.200-preview.20601.7
VS Code version: 1.52.1
C# Extension version: ms-dotnettools.csharp-1.23.8
.omnisharp 1.37.6-beta.16

## Steps to reproduce
1. settings.json:

```js
{
"csharp.unitTestDebuggingOptions": {
"allowFastEvaluate": true,
"enableStepFiltering": true,
"logging": {
"programOutput": true,
"elapsedTiming": true,
"engineLogging": false,
"exceptions": true,
"moduleLoad": false,
"threadExit": false,
"browserStdOut": false,
"processExit": true
},
"requireExactSource": true,
"suppressJITOptimizations": true,
"justMyCode": true,
"symbolOptions": {
"searchPaths": [],
"searchMicrosoftSymbolServer": false,
"searchNuGetOrgSymbolServer": false,
"moduleFilter": {
"mode": "loadOnlyIncluded",
"includeSymbolsNextToModules": false,
"includedModules": [
"MyUnitTests.dll",
]
}
}
}
}
```
2. Enable `All exceptions`
![image](https://user-images.githubusercontent.com/40987940/103710445-19ce4700-4fc6-11eb-9780-5d61b3f2ee60.png)
2. Debug a test.
3. Debugger breaks on non-user code.
![image](https://user-images.githubusercontent.com/40987940/103710523-46825e80-4fc6-11eb-8a47-a6df4c457fd9.png)

## Expected behavior

Breakpoint settings should use symbolOptions or justMyCode setting. Or maybe we can have a different checkboxes for this.

## Actual behavior

Symbols of `xunit.runner.visualstudio.dotnetcore.testadapter.dll` and `xunit.runner.utility.netcoreapp10.dll` are loaded and we see a breakpoint on exception inside the xunit code. I can't disable `All Exceptions` because if an exception is thrown in a test, we don't interrupt it with the `User-Unhandled Exceptions` setting.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.