dotnet / dotnet/vscode-csharp

Omnisharp log not helpful when .NET Core SDK is missing

Open
#3,193 0 comments 0 reactions 0 assignees View on GitHub
Feature Request Installation OmniSharp Triaged
Dominant language
TypeScript
Stars
3.1k
Forks
737
Avg merge
17h 56m
Merged PRs (30d)
21

Description

This is the log I see when the .NET Core SDK is missing on Windows.

https://gist.github.com/richlander/30cd2b81fb20a1cfab2ffa1d54f98285

I know it is missing because I also see this dialog in Code.

![2019-07-26 10_11_16-Window](https://user-images.githubusercontent.com/2608468/61971613-5ce45800-af94-11e9-8d23-25c05815722f.png)

In this scenario, I'd like to not see the [error about missing the Microsoft.Net.SDK](https://gist.github.com/richlander/30cd2b81fb20a1cfab2ffa1d54f98285#file-osharplog-txt-L46-L61) (which isn't directly actionable) and instead see one about not satisfying the .NET Core SDK requirement (hopefully much higher in log).

In short, the message / call to action in the dialog should be represented in the log and it isn't. The log should provide the same message and link to download the .NET Core SDK as what the dialog uses.

This is a mockup of the log I'd like to see: https://gist.github.com/richlander/7c44ff3344444c9c4869dc13469c7ab5

Main thing is addition of a new section that provides as much detail as the MSBuild section does:

```
[fail]: OmniSharp.DotnetCore.Locator
Located 0 .NET Core SDK instance(s)
Minimum required version: 2.1.801
```

That text isn't intended to be prescriptive but describe the general idea.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.