dotnet / dotnet/vblang

Question on target typed completion in Visual Studio

Open
#413 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
328
Forks
71
PR merge metrics
No merged PRs in 30d

Description

One of the folks working on Visual Studio asked me the following, and I wanted to get other people's opinion. Thoughts?

---

I’m working on a “Target-typed completion” feature where the user can reduce the completion list down to only items of the type expected at a given location (or implicitly convertible types).

For completion in C#, see the first gif in https://github.com/dotnet/roslyn/pull/34655

There would normally be tons more items in the list, but the user has clicked the “Target type match” filter at the bottom of the completion popup (left/right arrows in this screenshot), so the list has removed everything except these symbols which are actually valid at that location.

For completion in Visual Basic, I’ve gone and done the same experiment and I get a list with over 100 extra symbols, all from the Microsoft.VisualBasic assembly. While technically valid at a location expecting an Integer, these extra items make it hard to find the symbols that were easily discovered in C#.

So I think the questions are:

* Should we be blocking some or all of these symbols from showing up?
* If so, what heuristics should it be based on? Belonging to Microsoft.VisualBasic? Some other heuristic (or combination of heuristics)?

Please let me know what you think. 😊

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.