dotnet / dotnet/symreader

Revisit usage of ThrowExceptionForHR

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
55
Forks
50
PR merge metrics
No merged PRs in 30d

Description

This: ```hr != HResult.E_FAIL``` is suspicious.

```
internal static void ThrowExceptionForHR(int hr)
{
// E_FAIL indicates "no info".
// E_NOTIMPL indicates a lack of ISymUnmanagedReader support (in a particular implementation).
if (hr < 0 && hr != HResult.E_FAIL && hr != HResult.E_NOTIMPL)
{
Marshal.ThrowExceptionForHR(hr, s_ignoreIErrorInfo);
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.