dotnet / dotnet/symreader

ISymUnmanagedReader4.GetSourceServerData doesn't work with multipart sourcelink streams

Open
#278 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
55
Forks
50
PR merge metrics
No merged PRs in 30d

Description

The implementation of GetSourceServerData calls into Microsoft.DiaSymReader.Native.*
That code checks only the "sourcelink" stream. That's good enough for managed binaries.
However, it doesn't check multi-part streams emitted by the C++ tooling.
These streams are named "sourcelink$1", "sourcelink$2", etc.
For an example of how to do it right, see this code in PerfView: https://github.com/microsoft/perfview/blob/main/src/TraceEvent/Symbols/NativeSymbolModule.cs#L1136

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.