dotnet / dotnet/spark

We should re-enable running tests against netfx

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
2.1k
Forks
332
Avg merge
1d 20h
Merged PRs (30d)
9

Description

In PR https://github.com/dotnet/spark/pull/10 we disabled net461 targetframework for our tests because they were failing with a strong name failure.

```
 System.IO.FileLoadException : Could not load file or assembly 'Microsoft.Spark, Version=0.1.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)
Stack Trace:
 at Microsoft.Spark.UnitTest.SerDeTests.TestReadBytes()
Failed Microsoft.Spark.UnitTest.SerDeTests.TestReadAndWrite
```

cc: @eerhardt @rapoth @imback82 @danmosemsft

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.