dotnet / dotnet/sourcelink

Readme doesn't mention InformationalVersion or SourceRevisionId

Open
#1,694 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.4k
Forks
148
PR merge metrics
No merged PRs in 30d

Description

In [Source Link included in the .NET SDK](https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link) we learn the the assembly `InformationalVersion` attribute now includes the git commit hash thanks to sourcelink.

[MSBuild reference for .NET SDK projects#SourceRevisionId](https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#sourcerevisionid) also indicates that an MSBuild property is available.

Reading (ha) just the readme would lead one to believe that the only thing sourcelink does is embed some JSON in the PDB.

Could the readme be updated to at least hint about this additional functionality? Is there anything else hidden away somewhere?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.