dotnet / dotnet/source-build

000000 commit identifiers in nuspec files

Open
#5,444 5 comments 0 reactions 0 assignees View on GitHub
area-infra
Dominant language
No language data
Stars
287
Forks
145
Avg merge
1d 22h
Merged PRs (30d)
10

Description

After building the VMR with `--source-only`, I see a whole bunch of nuspec files that contain a commit sha of `00000`:

```
$ grep -rE '[^0-9]0000000000000000000000000000000000000000[^0-9]'
artifacts/obj/Microsoft.Extensions.DependencyInjection/Release/Microsoft.Extensions.DependencyInjection.11.0.0-dev.nuspec:
artifacts/obj/Microsoft.Extensions.DependencyInjection/Release/Microsoft.Extensions.DependencyInjection.11.0.0-dev.symbols.nuspec:
artifacts/obj/Microsoft.Extensions.Diagnostics.Abstractions/Release/Microsoft.Extensions.Diagnostics.Abstractions.11.0.0-dev.nuspec:
artifacts/obj/Microsoft.Extensions.Diagnostics.Abstractions/Release/Microsoft.Extensions.Diagnostics.Abstractions.11.0.0-dev.symbols.nuspec:
artifacts/obj/Microsoft.Extensions.DependencyModel/Release/Microsoft.Extensions.DependencyModel.11.0.0-dev.nuspec:
artifacts/obj/Microsoft.Extensions.DependencyModel/Release/Microsoft.Extensions.DependencyModel.11.0.0-dev.symbols.nuspec:
....
...

$ grep -rF 'commit="000' . | wc -l
498
```

This commit sha doesn't seem to end up in the built SDK, though.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.