dotnet / dotnet/source-build

Define unit test to ensure that telemetry is not enabled in source-built SDK

Open
#5,067 3 comments 0 reactions 0 assignees View on GitHub
area-testing
Dominant language
No language data
Stars
287
Forks
145
Avg merge
1d 22h
Merged PRs (30d)
10

Description

Telemetry gets enabled in the SDK when the `OfficialBuilder` property is set to `Microsoft`. For the changes in https://github.com/dotnet/sdk/pull/48327, it actually caused the SB job that was included into the UB pipeline to have telemetry enabled. This is because it gets included in the same stage as the UB jobs. This happens because the `buildSourceOnly` parameter is `false` for the stage when importing the vmr-build.yml variables template: https://github.com/dotnet/sdk/blob/fc7f6e80ac1bd3de3269a98ff92f201116ac59f1/eng/pipelines/templates/variables/vmr-build.yml#L58-L65.

A unit test would have caught this issue.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.