dotnet / dotnet/source-build

Clean up submodule GIT_DIR workaround

Open
#2,905 1 comment 0 reactions 0 assignees View on GitHub
area-infra
Dominant language
No language data
Stars
287
Forks
145
Avg merge
1d 22h
Merged PRs (30d)
10

Description

In https://github.com/dotnet/source-build-externals/pull/27 and https://github.com/dotnet/source-build/pull/2906 I introduced a workaround to prevent git from erroring out while applying patches in source-build-externals by forcing it to treat the repo as a non-git directory. This isn't an ideal workaround and in the unified build VMR we should be able to implement something better (probably by not removing the `objects` directory and treating the submodule as a real submodule).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.