dotnet / dotnet/source-build

Fix inconsistent IsDirectDependency="true" in baseline generation

Open
#1,873 0 comments 0 reactions 0 assignees View on GitHub
area-prebuilts
Dominant language
No language data
Stars
287
Forks
145
Avg merge
1d 22h
Merged PRs (30d)
10

Description

Baseline generation doesn't seem to consistently choose whether to include `IsDirectDependency="true"` when filtering to `Distinct` usages. I think this causes spurious changes in baseline updates:

```diff
-
+
```

We should do something like use the "maximal" `IsDirectDependency="true"` value (include it if *any* usages are `true`), or just trim this attribute entirely from the baseline. (You have to look at the full annotated usages file to be effective at removing prebuilts anyway.)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.