dotnet / dotnet/source-build-assets
Remove `IgnoreStandardErrorWarningFormat` from targeting pack generation
- Dominant language
- IL Assembly
- Stars
- 53
- Forks
- 74
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 18
Description
https://github.com/dotnet/source-build-reference-packages/blob/96f82a0db0bd0587e6523484b9b856a339c6cf30/src/targetPacks/Directory.Build.targets#L61
This setting hides real errors when generating assemblies via ILAsm. I noticed this when I accidentally removed this setting in the VMR. There are currently three errors that correspond to a single ILAsm bug which we should file an issue for so that everyone benefits.
```
/__w/1/s/src/targetPacks/ILsrc/microsoft.aspnetcore.app.ref/6.0.2/ref/net6.0/Microsoft.AspNetCore.Mvc.Core.il(58668) : warning : Duplicate param name '_' in method 'b__2_0'
/__w/1/s/src/targetPacks/ILsrc/microsoft.aspnetcore.app.ref/6.0.2/ref/net6.0/Microsoft.AspNetCore.Mvc.Core.il(58801) : warning : Duplicate param name '_' in method 'b__2_0'
/__w/1/s/artifacts/obj/Microsoft.AspNetCore.App.Ref.6.0.2/Release/netstandard2.0/ref/net6.0/Microsoft.AspNetCore.Components.patched.il(3478) : warning : Duplicate param name '_' in method 'b__7_0'
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.