dotnet / dotnet/sign

Unsupported/unexpected timestamp allowed

Open
#624 0 comments 0 reactions 0 assignees View on GitHub
bug Priority:2
Dominant language
C#
Stars
581
Forks
116
Avg merge
1d 2h
Merged PRs (30d)
8

Description

**Describe the bug**
If I hack a timestamp service to return a timestamp using SHA-1, Sign CLI blindly allows it. In the case of NuGet package signing, inner PE file timestamping succeeds, but NuGet package signing fails, and yet the overall exit code is still success (0).

Sign CLI should verify that the returned timestamp used the requested algorithm.

**Repro steps**
Very complicated. Need to hack the project's test timestamping service to repro.

**Expected behavior**
Timestamps with unsupported or unexpected algorithms should be rejected. The overall exit code should be failure.

**Actual behavior**
PE timestamping succeeds. NuGet package signing fails. Overall exit code is success (0).

CC @clairernovotny

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.