dotnet / dotnet/sign

MaxConcurrency should allow -1

Open
#558 1 comment 1 reaction 1 assignee Claimed by @dtivel View on GitHub
Priority:3
Dominant language
C#
Stars
581
Forks
116
Avg merge
1d 2h
Merged PRs (30d)
8

Description

[Sign CLI disallows -1 for the `--max-concurrency` option](https://github.com/dotnet/sign/blob/7b32935c42c720d96ceee799980a7f5ec2d2c296/src/Sign.Cli/CodeCommand.cs#L77-L89) just as [SignService did](https://github.com/dotnet/sign/blob/legacy-service/servicing/src/SignClient/SignCommand.cs#L252-L256), but [-1 has special meaning and should be allowed](https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.paralleloptions.maxdegreeofparallelism?view=net-7.0#remarks).

CC @clairernovotny

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.