dotnet / dotnet/sdk

`source-build` pipeline check is configured to require a PR comment

Closed
#56,236 2 comments 0 reactions 1 assignee Claimed by @MiYanni View on GitHub
Area-Infrastructure Bug
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

Revision 16 of the Azure DevOps configuration https://[dev.azure.com/dnceng-public/public/_apis/build/definitions/286?revision=16&api-version=7.1](https://dev.azure.com/dnceng-public/public/_apis/build/definitions/286?revision=16&api-version=7.1) made it so the source-build check requires a comment before it can run, despite it being a required check for PRs to merge on branches such as release/9.0.1xx. I believe this is still needed? I couldn't find a thread with reasoning as to why this was done by the engineering team.

It does not seem to be from a resource saving measure. It seems like we need someone with permission to fix that, or we need to decide to not run that check anymore. I would guess we want to turn the checks back on.

This was blocking https://github.com/dotnet/sdk/pull/56203 and other PRs.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.