dotnet / dotnet/sdk

Optional library initializer fingerprinting

Open
#53,342 0 comments 0 reactions 0 assignees View on GitHub
Area-AspNetCore Area-NetSDK Area-WasmSdk untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

### Is your feature request related to a problem? Please describe.

In the static files sdk, library initializers are currently forced to undergo fingerprinting. This bypasses options like `WasmFingerprintAssets`. At the moment this is the only type of file that undergoes this forced fingerprinting as far as my research goes.

It got introduced here: https://github.com/dotnet/sdk/pull/41619
I have no further context, if there is a reason I'd like to learn why.

It is causing issues in builds when working with .NET Browser Apps (WASM) which include a library initializer. At build time the the fingerprinted file is not created but the build system demands it and thus resolves its fingerprinted endpoint in the boot.json. This causes missing file issues downstream. It'll work with publishes but then I'd argue its still unexpected behavior for it to ignore the users setting to not fingerprint.

### Describe the solution you'd like

To make library initializer fingerprinting optional. It'll still be fingerprinted if `WasmFingerprintAssets=true`, but will act 'normally' if set to false.

### Additional context
I'm willing to PR if the proposal gets accepted

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.