dotnet / dotnet/sdk

Expand SDK archive tests to validate file permissions, ownership, and structure

Open
#53,085 0 comments 1 reaction 0 assignees View on GitHub
untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description


Following the work in #52910 to produce Windows archive tarballs and validate deduplication links, we should expand the `GivenSdkArchives` tests to cover additional archive properties.

## File permissions
- Verify that `tar.gz` archives preserve executable permissions (e.g., `dotnet`, `apphost` binaries should have the execute bit set after extraction)
- Verify that non-executable files (e.g., `.dll`, `.json`) do *not* have the execute bit set

## Archive structure
- Verify expected top-level directory structure exists (e.g., `sdk/`, `host/`, `shared/`)
- Verify no path traversal entries exist (paths containing `../`)

## File ownership (tar metadata)
- Verify tar entries have reasonable owner/group values (not root-owned when created on CI, or vice versa)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.