dotnet / dotnet/sdk

Need to rationalize MSBuildForwardingApp in AOT scenarios

Open
#52,988 1 comment 0 reactions 0 assignees View on GitHub
Area-dotnet AOT untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

In `MSBuildForwardingApp.ConcatTelemetryLogger`

```C#
Type loggerType = typeof(MSBuildLogger);
Type forwardingLoggerType = typeof(MSBuildForwardingLogger);

#pragma warning disable IL3000 // Avoid accessing Assembly file path when publishing as a single file
msbuildArgs.OtherMSBuildArgs.Add($"-distributedlogger:{loggerType.FullName},{loggerType.GetTypeInfo().Assembly.Location}*{forwardingLoggerType.FullName},{forwardingLoggerType.GetTypeInfo().Assembly.Location}");
#pragma warning restore IL3000
```

In AOT scenarios we'll need to have some code that sits in a `dll` for code that we'll run out of the AOT process.

I have not looked at all into how the logging works in this particular case. There may be additional work around telemetry logging to handle remoting build logging for telemetry.

cc: @MiYanni @baronfel

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.