dotnet / dotnet/sdk

Replace obsolete WorkspaceFailed with RegisterWorkspaceFailedHandler in dotnet-watch IncrementalMSBuildWorkspace.cs

Open
#49,725 0 comments 0 reactions 1 assignee Claimed by @tmat View on GitHub
Area-Watch untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

In https://github.com/dotnet/dotnet/pull/1428 we suppressed the obsoletion warning for
> src/sdk/src/BuiltInTools/dotnet-watch/HotReload/IncrementalMSBuildWorkspace.cs(21,9): error CS0618: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Workspace.WorkspaceFailed' is obsolete: 'Use RegisterWorkspaceFailedHandler instead, which by default will no longer run on the UI thread.'

This should be reverted and the new API used instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.