dotnet / dotnet/sdk

New Parser Feature Needed for MSBuild Extra Options in Help Command

Open
#46,822 0 comments 0 reactions 1 assignee Claimed by @nagilson View on GitHub
Area-NetSDK untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

### Describe
Several tests are skipped due to the need for a new parser feature. These tests involve verifying the help information for the `build, clean, pack, publish, and restore` commands. The current parser cannot correctly handle the text output for MSBuild extra options, so these tests cannot run properly.

Specifically, these tests aim to ensure that when the --help command is executed, the output includes information about MSBuild extra options. However, due to the limitations of the parser, these tests are marked as skipped.

To resolve this issue, a new parser feature needs to be developed that can correctly parse and display the help text for MSBuild extra options. This will ensure that the tests can run successfully and verify the correctness of the output.

The relevant code snippet is:
```csharp
[Theory(Skip = "https://github.com/dotnet/sdk/issues/46822")]
[InlineData("build")]
[InlineData("clean")]
[InlineData("pack")]
[InlineData("publish")]
[InlineData("restore")]
public void When_help_is_invoked_Then_MSBuild_extra_options_text_is_included_in_output(string commandName)
{
const string MSBuildHelpText = " Any extra options that should be passed to MSBuild. See 'dotnet msbuild -h' for available options.";

var projectDirectory = _testAssetsManager.CreateTestDirectory(identifier: commandName);
var result = new DotnetCommand(Log)
.WithWorkingDirectory(projectDirectory.Path)
.Execute(commandName, "--help");

result.ExitCode.Should().Be(0);
result.StdOut.Should().Contain(MSBuildHelpText);
}

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.