dotnet / dotnet/sdk

Make RestoreActionConfig use correct-by-design

Open
#45,595 0 comments 0 reactions 0 assignees View on GitHub
Area-CLI
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

Per https://github.com/dotnet/sdk/pull/45312#discussion_r1894132387:

- _I feel like I've seen this 'verbosity needs to be downstream of some other configuration' problem in a few different places in the codebase - is it something that you think we could detect and extract to prevent playing whack-a-mole?_

- _the set of parameters to the RestoreActionConfig seem very 'regular' (in the sense of common/not-changing) - is there a way we could enforce that commands that use RestoreActionConfig have the required options applied to them and something in the way those commands are processed/executed automatically configures a RestoreActionConfig? Again focusing on 'How can we be consistent by design' here instead of playing whack-a-mole. Maybe a middleware or extension method on ParseResult or something?_

There may be more components that we should also look into making correct-by-design; these two were just relevant to #45312.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.