dotnet / dotnet/sdk

Follow-up on updating maintenance-packages dependencies conditioned to only DotNetBuildSourceOnly != true

Open
#45,155 0 comments 0 reactions 1 assignee Claimed by @carlossanlop View on GitHub
area-runtime Infrastructure
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

[This sdk deps flow PR](https://github.com/dotnet/sdk/pull/45042) from runtime failed because we shipped new package versions from dotnet/maintenance-packages for System.Buffers, System.Memory, System.Runtime.CompilerServices.Unsafe, System.Numerics.Vectors and System.Threading.Tasks.Extensions.

System.Memory in particular is failing in dotnet/roslyn due to not being able to find System.ReadOnlySpan, which is provided by the package. The underlying root cause is that msbuild is forcing the package version to downgrade. Until we get msbuild to update the package versions, roslyn cannot have those package versions updated.

The sdk deps flow PR is getting at least 2 patches to condition those deps new versions to only happen when _not_ in source build. We will need to take those conditions eventually when the timing is right (maily after msbuild update flows to roslyn).

cc @ViktorHofer @ericstj

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.