dotnet / dotnet/sdk

ILLInk fix the usage of treatWarningsAsErrors

Open
#45,134 7 comments 0 reactions 0 assignees View on GitHub
Area-ILLink untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

### Describe the bug
The [ PR 10942](https://github.com/dotnet/msbuild/pull/10942) in msbuild has changed the way WarningsAsErrors are treated. Unfortunately this is incompatible with the way ILLink currenctly uses them.
We need to decide how to handle this case since the MSBuild team wants this change for the sake of consistency even though it is more breaking than expected.

### To Reproduce
Enable the ILLink_can_treat_warnings_not_as_errors, ILLink_can_treat_warnings_as_errors tests within the GivenThatWeWantToRunILLink.cs test file.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.