dotnet / dotnet/sdk

SFI: Remove passwords from WebSdk/README.md

Open
#44,860 0 comments 0 reactions 0 assignees View on GitHub
Area-WebSDK untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

The [WebSdk/README.md](https://github.com/dotnet/sdk/blob/main/src/WebSdk/README.md) contains `password` 31 times. Per [this comment](https://github.com/dotnet/sdk/pull/44761#issuecomment-2465962140) by @baronfel:

> I'd strongly consider changing the doc to some mechanism that does not ingest secrets of any kind into MSBuild via Properties - once something is an MSBuild property it is visible to all Task and MSBuild logic that runs in that same build, so unless you are strictly auditing the build logic you use (including build logic from NuGet packages, etc) you're exposing yourself.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.