dotnet / dotnet/sdk

Package validation fail

Open
#41,199 1 comment 0 reactions 1 assignee Claimed by @ViktorHofer View on GitHub
Area-ApiCompat untriaged
Dominant language
C#
Stars
3.2k
Forks
1.3k
PR merge metrics
PR metrics pending

Description

### Describe the bug
When updating our `PackageValidationBaselineVersion` the build fails on package validation. However when running our build with `/p:ApiCompatGenerateSuppressionFile=true` to update the files as instructed, the only differece in the output is that the command deleted the comments we had on the xlm files:
![image](https://github.com/dotnet/sdk/assets/10743736/863911d7-296d-47a8-9ee2-df50dece9497)

You can see it in https://github.com/dotnet/msbuild/pull/10116

### Repro
- Download MSBuild repo
- Update the `PackageValidationBaselineVersion` to 17.10.4 (the new release version)
- Run `.\build.cmd -c Release -pack /p:ApiCompatGenerateSuppressionFile=true` from msbuild repo source.
- Check the differences in the xml files.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.