dotnet / dotnet/samples

Roslyn code analyzer samples contain install.ps1/uninstall.ps1 that are no longer supported

Open
#5,313 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
3.7k
Forks
5.1k
Avg merge
9h 11m
Merged PRs (30d)
1

Description

Roslyn code analyzer [samples](https://github.com/dotnet/samples/tree/main/csharp/roslyn-sdk/Tutorials/MakeConst/MakeConst.Package/tools) contain install.ps1/unistall.ps1, but they are no longer supported:
https://devblogs.microsoft.com/nuget/nuget-now-fully-integrated-into-msbuild/#will-existing-nuget-packages-work-if-i-am-using-packagereference-for-wpf-windows-forms-or-asp-net-projects

Additionally, it seems that it's easier to include files in the package using `Content` element instead of using `TargetsForTfmSpecificContentInPackage` in the [project file](https://github.com/dotnet/samples/blob/main/csharp/roslyn-sdk/Tutorials/MakeConst/MakeConst.Package/MakeConst.Package.csproj), like this:

```xml

analyzers\dotnet\cs

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.